Skip to content

Replace Jackson 2 API with Jackson 3#684

Merged
uhafner merged 3 commits intojenkinsci:mainfrom
jonesbusy:feature/jackson3
Apr 15, 2026
Merged

Replace Jackson 2 API with Jackson 3#684
uhafner merged 3 commits intojenkinsci:mainfrom
jonesbusy:feature/jackson3

Conversation

@jonesbusy
Copy link
Copy Markdown
Contributor

Jackson3 update

Testing done

mvn -DskipTests clean install

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@jonesbusy
Copy link
Copy Markdown
Contributor Author

@uhafner If any interest

@jonesbusy jonesbusy marked this pull request as ready for review March 1, 2026 18:22
@jonesbusy jonesbusy changed the title Jackson3 update Jackson 3 update Mar 1, 2026
Copy link
Copy Markdown
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally managed it to move the baseline to a more modern Jenkins version...

Can't we simply ignore the exceptions now?

@github-actions github-actions bot requested a review from uhafner April 13, 2026 11:48
@uhafner
Copy link
Copy Markdown
Member

uhafner commented Apr 13, 2026

Can't we simply ignore the exceptions now?

It seems that it still makes sense to catch the exceptions. (Or we should delete the test? Throwing a runtime exception might help to find broken configurations)

@jonesbusy
Copy link
Copy Markdown
Contributor Author

Can't we simply ignore the exceptions now?

It seems that it still makes sense to catch the exceptions. (Or we should delete the test? Throwing a runtime exception might help to find broken configurations)

Ok I will check tomorrow. I think it doesn't harm to catch it and rethrow a different runtime exception

@github-actions
Copy link
Copy Markdown

☀️   Quality Monitor

Tests

   JUnit   Unit Tests: ✅ successful — 190 passed
   🚀   Integration Tests: ✅ successful — 148 passed, 7 skipped
   ⛔   Architecture Tests: ✅ successful — 15 passed

Coverage for New Code

   〰️   Line Coverage: 50.00% — 1 missed lines
   ➰   Branch Coverage: 100.00% — perfect 🎉

Coverage for Whole Project

   〰️   Line Coverage: 76.24% — 727 missed lines
   ➰   Branch Coverage: 66.63% — 292 missed branches

Style

   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   ☕   Java Compiler: No warnings

Bugs

   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs

Vulnerabilities

   🛡️   OWASP Dependency Check: 206 vulnerabilities — error: 18, high: 53, normal: 129, low: 6

Software Metrics

   🌀   Cyclomatic Complexity: 1028 (total)
   💭   Cognitive Complexity: 562 (total)
   ➿   N-Path Complexity: 1385 (total)
   📏   Lines of Code: 12044 (total)
   📝   Non Commenting Source Statements: 4058 (total)
   🔗   Class Cohesion: 100.00% (maximum)
   ⚖️   Weight of Class: 100.00% (maximum)

🚦 Quality Gates

Overall Status: ❗ UNSTABLE

✅ Passed Gates

  • ✅ Overall Tests Success Rate: 100.00 >= 100.00
  • ✅ Branch Coverage in New Code: 100.00 >= 90.00
  • ✅ Potential Bugs in Whole Project: 0.00 <= 0.00
  • ✅ Style Violation in Whole Project: 0.00 <= 0.00

❌ Failed Gates

  • ❌ Line Coverage in New Code: 50.00 >= 90.00

Created by Quality Monitor v4.10.0 (#be1b382). More details are shown in the GitHub Checks Result.

@uhafner uhafner added the internal Internal changes without user or API impact label Apr 15, 2026
@uhafner uhafner merged commit 6007ac9 into jenkinsci:main Apr 15, 2026
31 of 32 checks passed
@uhafner uhafner changed the title Jackson 3 update Replace Jackson 2 API with Jackson 3 Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes without user or API impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants