Pass SQS messages to webhook plugin

[thomaslorentsen]

Prevents a null value error when an SQS message can be treated
as a SNS message which does not contain the expected
json payload

[kramachandran1980]

Can someone please review and merge this? we seem to be hitting this issue.

[nemo83]

@kramachandran1980 did you have a chance to test/regressions test this PR ? I've stopped using this plugin a while ago and I am not able to test it.

[thomaslorentsen]

@kramachandran1980 We managed to get round this issue by only passing the GitHook messages to SNS. You just need to ensure that the header X-GitHub-Event is being added to the SNS message.

That should get around the problem without this fix.

[kramachandran1980]

@nemo83 - No. not yet. I am new to building plugins and trying to build and deploy it in my linux host which runs jenkins. If there is any way, you can provide the jar file - i can test it quickly in my setup.

@thomaslorentsen: My github webhook payload contains: X-GitHub-Event: push. My setup is:
github PR's call a webhook on commit. This webhook puts the payload in an AWS SQS queue. Jenkins is configured to read from this queue and call a job. Observing the "null value error" sometimes. When i try to redeliver the webhook from github 3/4 times, it passes intermittently. How can i get SNS into this now? I see that github services are being deprecated. Any feedback would be appreciated.

[thomaslorentsen]

@kramachandran1980 yes, the error is because you are inserting directly into SQS with GitHub.

Due to GitHub deprecating the feature, I’m now pointing a webhook to a AWS Lambda app that puts the payload into an SNS queue with the X-GitHub-Event added to the header.

This is allowing me to not expose my Jenkins to the Internet.