Fix Proxy requiring Authentication usage#137
Open
lenaing wants to merge 3 commits intojenkinsci:masterfrom
Open
Fix Proxy requiring Authentication usage#137lenaing wants to merge 3 commits intojenkinsci:masterfrom
lenaing wants to merge 3 commits intojenkinsci:masterfrom
Conversation
|
I think my issue is related. When I use the proxyAuthentication parameter, an After comparing with a curl --proxy --proxy-user, it seems that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
This PR intends to fix proxy requiring authentication usage and wrong documentation about it.
I could not find a way to use proxy requiring an authentication with preemptive authentication enabled, even in a simple out-of-this-PR context.
Java is not my main language so there may be a more elegant / efficient way to fix this issue.
Kind regards,
Tested against both authenticated and unauthenticaded Squid
mysquid.confRunning the Squids
Tests
pipeline { agent any stages { stage('Test') { steps { // No proxy httpRequest url: 'https://httpbin.org/' httpRequest url: 'https://httpbin.org/basic-auth/user/passwd', authentication: 'httpbin' // Proxy without authentication httpRequest url: 'https://httpbin.org/', httpProxy: 'http://127.0.0.1:3129' httpRequest url: 'https://httpbin.org/basic-auth/user/passwd', authentication: 'httpbin', httpProxy: 'http://127.0.0.1:3129' // Proxy with authentication httpRequest url: 'https://httpbin.org/', httpProxy: 'http://127.0.0.1:3128', proxyAuthentication: 'proxy-auth' httpRequest url: 'https://httpbin.org/basic-auth/user/passwd', authentication: 'httpbin', httpProxy: 'http://127.0.0.1:3128', proxyAuthentication: 'proxy-auth' } } } }