Enhanced getFillItems() method in HttpMode class#143
Enhanced getFillItems() method in HttpMode class#143iqbalrohail wants to merge 2 commits intojenkinsci:masterfrom
Conversation
done this to populate a ListBoxModel with HttpMode enum values
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
This is an interesting first step, but I think that it is not providing enough value to the user to justify the change. The value of httpMode.toString() is the same as the value of httpMode.name(). Thus, the additional parameter does not provide any better information for the user than the existing parameter.
If you'd like to continue on this path, then the second argument should provide more information for the user than the first argument does. It might be a combination of the httpMode and a brief description of that mode possibly using some portion of the RFC-9110 method definitions or the Wikipedia request method descriptions.
Remember that the second parameter is the text that will be displayed to the user in the dropdown list that is presented. I think it should include the httpMode.name() as the first text in the dropdown list so that the selected method is the first text read by the user.. Additional explanation should come after the name of the method.
|
@iqbalrohail would you like to continue with this pull request or should I close it? |
2 participants
done this to populate a ListBoxModel with HttpMode enum values
This change will likely improve the user experience by providing a better list of options for selecting the HTTP mode in Jenkins build steps.
Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did