A possible for JENKINS-23293#2
Open
zjfroot wants to merge 2 commits into
Open
Conversation
…ecutors, instead of computer.countIdle()
|
plugins » leastload-plugin #13 SUCCESS |
Author
|
The idea was replacing replace computer.countIdle() with ExecutorChunk's size, which I suppose it always represent the idling executors on a computer/slave |
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Member
|
I'll take a look at this not sure if the ExecutorChunk size will always represent the idling executors. The documentation is a little vague. |
Author
|
Great. Meanwhile I am running my patch on our private jenkins to see anything strange will happen. |
|
@zjfroot have you noticed any issues with your patch ? |
|
I am facing this exact issue. I know it is an old thread, but was this implemented? can be re-visited? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tried to make a possible fix for JENKINS-23293
When jobs launched from Multijob plugin or many sub jobs triggered at the same time by a "master" job, computer.countIdle() does not return the correct idling number of executors.
I am not sure this is the right fix, so any discussion is welcomed.