Conversation
adutt-mw
requested review from
Vahila,
davidbuzinski,
mw-hrastega,
mw-kapilg,
sameagen-MW and
tsharmaMW
as code owners
|
Thanks Abhishek for working on this! I added few minor comments. |
sameagen-MW
left a comment
sameagen-MW
left a comment
There was a problem hiding this comment.
Overall, this looks really clean to me, thanks for putting it together! Could you ping me a link to the Jenkins job configuration as well? It's somewhat unfortunate that we can't have that under source control as well.
I'll also follow up because I need to do security-oriented pass.
mw-kapilg
left a comment
mw-kapilg
left a comment
There was a problem hiding this comment.
Overall LGTM! Thanks for adding these
sameagen-MW
left a comment
sameagen-MW
left a comment
There was a problem hiding this comment.
Looks good to me overall! Can you confirm that this workflow is protected so that others can't trigger workflow runs? It would present a security vulnerability since an attacker could change the python script and use the Jenkins credentials to execute arbitrary code on the self-hosted runner if so.
I think this is ready for submission after confirming that, thanks for working on this and sorry for the delay in getting my review out.
| time.sleep(10) | ||
|
|
||
| print(f" [ERROR] Timeout: Build #{build_number} did not complete within {timeout_mins} minutes.") | ||
| return "TIMEOUT" |
There was a problem hiding this comment.
I think we probably want to throw / catch an exception from here rather than returning a sentinel value. Sentinel values have some significant drawbacks when it comes to maintainability.
Hi, I checked regarding this, GitHub provides a specific toggle to "Require approval for all outside contributors". This ensures that no workflow from a fork can execute on our hardware or access repository secrets until a maintainer manually reviews the code and clicks "Approve and run". Since I don't have admin access to the repository, someone else has to toggle it. |
5 participants
Description
This PR implements an automated verification workflow for cross-platform tests on Jenkins. It triggers builds, verifies artifacts, and clean up resources on the machine.
Changes
src/test/cross-platform-tests/jenkins_verifier.py:.github/workflows/cross-platform-tests.yml:workflow_dispatch).Test Run: https://github.com/jenkinsci/matlab-plugin/actions/runs/22570260111/job/65376040065