Skip to content

Add missing checkbox model for option to "Protect source code viewer"#318

Merged
uhafner merged 3 commits into
jenkinsci:mainfrom
akash-manna-sky:issue-298
Jun 5, 2026
Merged

Add missing checkbox model for option to "Protect source code viewer"#318
uhafner merged 3 commits into
jenkinsci:mainfrom
akash-manna-sky:issue-298

Conversation

@akash-manna-sky

Copy link
Copy Markdown
Contributor

Checkbox "Protect source code viewer by Jenkins WORKSPACE permission" always unchecked

Fixes #298

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@uhafner uhafner added the bug Bugs or performance problems label Jun 4, 2026
@uhafner uhafner changed the title Checkbox "Protect source code viewer by Jenkins WORKSPACE permission" always unchecked Add missing checkbox model for option to "Protect source code viewer" Jun 4, 2026

@uhafner uhafner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am a little bit late. It seems that I did not enable notifications in this repository.

While you change fixes the checkbox problem, I think the main problem is a different one. Actually I think that the checkbox is shown in the wrong item: it should not be shown in the appearance section, it should be shown in the security section (below the existing prism entry).

So I would prefer if you move the jelly code from the PrismAppearanceConfiguration to the PrismConfiguration. Then the Java code does not need to be touched at all when I see that correctly...

@akash-manna-sky akash-manna-sky marked this pull request as ready for review June 4, 2026 15:48
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

☀️   Quality Monitor

Tests

   JUnit   Unit Tests: ✅ successful — 42 passed $\textsf{(±0)}$, 2 skipped $\textsf{(±0)}$
   🚀   Integration Tests: ✅ successful — 24 passed $\textsf{(±0)}$
   ⛔   Architecture Tests: ✅ successful — 15 passed $\textsf{(±0)}$

Coverage for New Code

   〰️   Line Coverage: 100.00% — perfect 🎉
   ➰   Branch Coverage: 100.00% — perfect 🎉

Coverage for Whole Project

   〰️   Line Coverage: 79.35% $\textsf{(±0)}$ — 89 missed lines
   ➰   Branch Coverage: 73.38% $\textsf{(±0)}$ — 37 missed branches

Style

   CheckStyle   CheckStyle: No warnings $\textsf{(±0)}$
   PMD   PMD: No warnings $\textsf{(±0)}$
   ☕   Java Compiler: No warnings $\textsf{(±0)}$

Bugs

   SpotBugs   SpotBugs: No bugs $\textsf{(±0)}$
   🐛   Error Prone: No bugs $\textsf{(±0)}$

Vulnerabilities

   🛡️   OWASP Dependency Check: 201 vulnerabilities $\color{green}{\textsf{(+201)}}$ — error: 14, high: 59, normal: 121, low: 7

Software Metrics

   🌀   Cyclomatic Complexity: 163 (total)
   💭   Cognitive Complexity: 72 (total)
   ➿   N-Path Complexity: 236 (total)
   📏   Lines of Code: 1851 (total)
   📝   Non Commenting Source Statements: 599 (total)
   🔗   Class Cohesion: 100.00% (maximum)
   ⚖️   Weight of Class: 100.00% (maximum)

📌 Reference Results

Delta reports computed against the reference results of 48156c1 in workflow run 26753986411.

🚦 Quality Gates

Overall Status: ✅ SUCCESS

✅ Passed Gates

  • ✅ Overall Tests Success Rate: 100.00 >= 100.00
  • ✅ Line Coverage in New Code: 100.00 >= 90.00
  • ✅ Branch Coverage in New Code: 100.00 >= 90.00
  • ✅ Potential Bugs in Whole Project: 0.00 <= 0.00
  • ✅ Style Violation in Whole Project: 0.00 <= 0.00

Created by Quality Monitor v4.15.0 (#82d77af). More details are shown in the GitHub Checks Result.

@akash-manna-sky akash-manna-sky requested a review from uhafner June 4, 2026 16:15

@uhafner uhafner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So this change makes much more sense.

@uhafner uhafner merged commit 034eb0b into jenkinsci:main Jun 5, 2026
30 checks passed
@akash-manna-sky akash-manna-sky deleted the issue-298 branch June 5, 2026 12:01
@akash-manna-sky

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs or performance problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checkbox "Protect source code viewer by Jenkins WORKSPACE permission" always unchecked

2 participants