Add missing checkbox model for option to "Protect source code viewer"#318
Conversation
uhafner
left a comment
There was a problem hiding this comment.
Sorry, I am a little bit late. It seems that I did not enable notifications in this repository.
While you change fixes the checkbox problem, I think the main problem is a different one. Actually I think that the checkbox is shown in the wrong item: it should not be shown in the appearance section, it should be shown in the security section (below the existing prism entry).
So I would prefer if you move the jelly code from the PrismAppearanceConfiguration to the PrismConfiguration. Then the Java code does not need to be touched at all when I see that correctly...
…ission always unchecked" This reverts commit 03fbc72.
☀️ Quality MonitorTests Coverage for New Code 〰️ Line Coverage: 100.00% — perfect 🎉 Coverage for Whole Project 〰️ Line Coverage: 79.35% Style Bugs Vulnerabilities 🛡️ OWASP Dependency Check: 201 vulnerabilities Software Metrics 🌀 Cyclomatic Complexity: 163 (total) 📌 Reference ResultsDelta reports computed against the reference results of 48156c1 in workflow run 26753986411. 🚦 Quality GatesOverall Status: ✅ SUCCESS✅ Passed Gates
Created by Quality Monitor v4.15.0 (#82d77af). More details are shown in the GitHub Checks Result. |
uhafner
left a comment
There was a problem hiding this comment.
Thanks! So this change makes much more sense.
|
Thanks! |
Checkbox "Protect source code viewer by Jenkins WORKSPACE permission" always unchecked
Fixes #298
Testing done
Submitter checklist