[JENKINS-45362] Workaround for not detecting changes in externals#191
[JENKINS-45362] Workaround for not detecting changes in externals#191r-funke wants to merge 1 commit intojenkinsci:masterfrom
Conversation
|
@jenkinsci/code-reviewers |
|
I'm not sure it's a great idea to add a workaround with a UI option. |
|
If #189 gets accepted, what about enabling the workaround whenever additional credentials have been enabled? @jglick commented on this that 1) additional credentials may have been specified but not used, and 2) there may be externals which do not require additional credentials. Regarding 1) I think that this will rarely happen. But if it does, the workaround doesn't seem to break anything. Regarding 2) my experience is that it is always necessary to specify additional credentials when using externals to avoid ISVNAuthentication exception (JENKINS-35227). |
|
Any further suggestions? |
jglick
left a comment
There was a problem hiding this comment.
I do not think we ever want to have nondeterministic revisions.
|
Any news about this? |
|
this is still an issue.... the workaround for this is adding the normal credentials again as additional credentials... |
Like discussed in PR #189 the clean solution would be to extend SCMRevisionImpl to encode the revisions of all externals. But setting isDeterministic() to false is a simple workaround that solves the issue.