Add two items to meeting and one item to conference#46
Open
lex-files wants to merge 2 commits into
Open
Conversation
Contributor
Owner
|
Yep, merge conflict. See #42 for a review of ways we can proceed. |
Contributor
|
Hey @lex-files, this conflict isn't your fault (it's because multiple people were editing the same file), but because your PR is being merged later, it cropped up. If you're looking at this conversation on GitHub you should be able to resolve the conflict right here, and I'm happy to talk through it with you in person later today if you'd like! Let me know. |
jennybc
requested changes
Apr 16, 2019
jennybc
left a comment
jennybc
left a comment
Owner
There was a problem hiding this comment.
A closing " needs to be restored to one of the entries. Note that this also is flagged via the automated tests, which is a handy thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.