Updated sqlx version, and also applied a couple of minor fixes.#16
Open
arshadm wants to merge 3 commits intojeremychone:mainfrom
Open
Updated sqlx version, and also applied a couple of minor fixes.#16arshadm wants to merge 3 commits intojeremychone:mainfrom
arshadm wants to merge 3 commits intojeremychone:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on a production app which is using sqlb, we use both postgres and sqlite. Unfortunately, upgrading to sqlx 0.8.0 caused a dependency issue with sqlb as it is on 0.7.x and the sqlite dependencies are incompatible.
I have update the sqlx dependency, and also fixed a compilation issue due to a missing feature which the latest version of cargo picked up.
I also modified the tests to pickup the database URL from the environment variable DATABASE_URL (the existing value is used as fallback). This is the same variable that the sqlx macros use.