Open
Conversation
- Fix test implementation details - Mock pandas.read_excel function
|
get_listed_securities throws an error, please investigate |
Author
|
@ShahinNamin that's the original error which I addressed in point number 2 in my PR comment (above). I re-ran the tests on my fork to be certain. I get all tests passing. Can you please confirm if there's a discrepancy? |
|
My bad, the error is in the master branch. If your pull request is approved, it will be resolved. Thanks @RamParameswaran |
|
Thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies two patches to fix failing tests:
testGetSecurityInfoLive--> previously used ticker symbol ("CBAPC") has been suspended on the ASX. Replaced with "CBAPD"Original error:
testGetListedSecuritiesLive--> error decoding the XLS file for listed securities. In this PR, I'm using Pandas to read the excel file. This simplifies the code. But it adds two dependencies:pandasandxlrdOriginal error:
Great library 👍