Add na="null_specials" to differentiate Inf/NaN from NA#462
Open
r2evans wants to merge 1 commit intojeroen:masterfrom
Open
Add na="null_specials" to differentiate Inf/NaN from NA#462r2evans wants to merge 1 commit intojeroen:masterfrom
na="null_specials" to differentiate Inf/NaN from NA#462r2evans wants to merge 1 commit intojeroen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm being optimistic that you'll be amenable to addressing #461. It's an opt-in addition to
na=that defaults to unchanged legacy behavior.Previous behavior:
With this patch:
I added unit-tests to confirm this behavior. All other tests pass.
In full disclosure, there is a slight performance dip. In the C code I tried to be a bit more "unrolled" to mitigate this, but it's non-zero.
The same method using
n <- 10, a more modest comparison, not demonstrating a significant change.