Skip to content

fix(web): studio grid and research search polish #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerry609 merged 1 commit into from
Mar 13, 2026
Merged

fix(web): studio grid and research search polish #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/components/research/SearchBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export function SearchBox({
>
<div
className={cn(
"relative rounded-2xl border bg-background shadow-md transition-all duration-200",
"relative overflow-hidden rounded-2xl border bg-background shadow-md transition-all duration-200",
"focus-within:shadow-lg focus-within:border-primary/50",
"hover:shadow-lg",
disabled && "opacity-60"
Expand All @@ -189,7 +189,7 @@ export function SearchBox({
placeholder={placeholder}
disabled={disabled || isSearching}
className={cn(
"min-h-[56px] max-h-[200px] resize-none border-0 bg-transparent",
"min-h-[56px] max-h-[200px] resize-none border-0 bg-transparent !rounded-none !border-0 !shadow-none",
Copy link

@gemini-code-assist gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line includes both border-0 and !border-0. While tailwind-merge correctly resolves this by prioritizing the !border-0 class (due to the !important flag), including the redundant border-0 class can be confusing for future maintenance. It's best to remove the redundant class for improved code clarity.

Suggested change
"min-h-[56px] max-h-[200px] resize-none border-0 bg-transparent !rounded-none !border-0 !shadow-none",
"min-h-[56px] max-h-[200px] resize-none bg-transparent !rounded-none !border-0 !shadow-none",

"px-5 sm:px-6 pt-4 pb-[56px]",
"text-base placeholder:text-muted-foreground/50",
"focus-visible:ring-0 focus-visible:ring-offset-0"
Expand Down
11 changes: 9 additions & 2 deletions web/src/components/studio/PaperGallery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,9 +430,12 @@ export function PaperGallery() {
</div>
) : (
/* Tiled catalog grid (Image-2 style) */
<div className="grid grid-cols-1 gap-px border border-zinc-300 bg-zinc-300 md:grid-cols-2 xl:grid-cols-4">
<div className="grid grid-cols-1 gap-0 md:grid-cols-2 xl:grid-cols-4">
{sortedPapers.map((paper, index) => {
const rowIndex = Math.floor(index / gridColumns)
const colIndex = index % gridColumns
const isFirstRow = rowIndex === 0
const isFirstCol = colIndex === 0
return (
<article
key={paper.id}
Expand All @@ -445,7 +448,11 @@ export function PaperGallery() {
}}
role="button"
tabIndex={0}
className="group relative flex min-h-[300px] cursor-pointer flex-col bg-background p-6 text-left transition-colors hover:bg-background focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-zinc-500 focus-visible:ring-offset-2"
className={cn(
"group relative flex min-h-[300px] cursor-pointer flex-col border-r border-b border-zinc-300 bg-background p-6 text-left transition-colors hover:bg-background focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-zinc-500 focus-visible:ring-offset-2",
isFirstRow && "border-t",
isFirstCol && "border-l",
)}
>
{/* Delete button */}
<button
Expand Down
Loading