Make eof() consider padding when reading less than block size#17
Open
valga wants to merge 2 commits intojeskew:masterfrom
Open
Make eof() consider padding when reading less than block size#17valga wants to merge 2 commits intojeskew:masterfrom
valga wants to merge 2 commits intojeskew:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 113 116 +3
===========================================
Files 12 12
Lines 300 304 +4
===========================================
+ Hits 300 304 +4
Continue to review full report at Codecov.
|
substr() returns false when offset is greater than total length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading from AES encrypting stream with chunk length < block size
eof()returnstruetoo early leaving a part of padding in the buffer.