Open
Conversation
I've upgraded code and dependencies to PHP 8.1+. I decided to don't care about PHP 7 as it is unmaintained anymore, so changes are not bc. Although interfaces hasn't changed that much, I only added types where they were missing. I'm not sure to one change I've done to AesGcmEncryptingStream.php and AesGcmDecryptingStream.php. After switch to PHP 8, deprecation errors occurred because of StreamDecoratorTrait dynamic property declaration and I don't see any good solution to fix them for now. So I added #[\AllowDynamicProperties] to ignore them. They are not breaking anything and if there were in the future, there are tests covering it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've upgraded code and dependencies to PHP 8.1+.
I decided to not care about PHP 7 as it is
unmaintained... So changes are not bc.
Although interfaces hasn't changed that much, I only added types where they were missing.
After switch to PHP 8, deprecation errors occurred because of StreamDecoratorTrait dynamic property declaration and I don't see any good solution to fix them for now. So I added #[\AllowDynamicProperties] to ignore them. They are not breaking anything and if they will in the future, there are tests covering it.