Return more precise values for newer Envoys#70
Open
gtdiehl wants to merge 152 commits intojesserizzo:mainfrom
gtdiehl:precise_values
Open
Return more precise values for newer Envoys#70gtdiehl wants to merge 152 commits intojesserizzo:mainfrom gtdiehl:precise_values
gtdiehl wants to merge 152 commits intojesserizzo:mainfrom
gtdiehl:precise_values
Conversation
Also fix url
Improve version detection
Update from origin
Fix Original Envoy detection
Add retries when gathering Inverter data
Return None for Inverter data for Envoy with <3.9 firmware
- support passing in shared httpx client - get pylint rating to 10/10
Cleanup detection and avoid calling endpoints that are not present
Bumping version for clean up in PR #64
* Rename master to main
Envoy-S return float values that are more precise as they have values 3 decimal points to the right. For these the API will return the actual value and not a rounded integer value
Precise values only come when a CT is used. When production metering is enabled the API returns a float, otherwise an integer is returned.
Given directory names to indicate if Production/Consumption metering is enabled. Updated tests for new float values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy-S return float values that are more precise as they have values 3 decimal points to the right. For these the API will return the actual value and not a rounded integer value
Fixes #55
Pull request recommendations:
Thanks for contributing!