Use encoding.TextMarshaler/encoding.TextUnmarshaler if present#413
Open
drshriveer wants to merge 1 commit intojessevdk:mainfrom
Open
Use encoding.TextMarshaler/encoding.TextUnmarshaler if present#413drshriveer wants to merge 1 commit intojessevdk:mainfrom
drshriveer wants to merge 1 commit intojessevdk:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
In order to parse custom flag types it is currently necessary to implement the
flags.Unmarshalerand optionally theflags.Marshalerinterface. That interface is specific to this library, but many types already make use ofencoding.TextMarshalerandencoding.TextUnmarshalerwhich is a bit more standardized. It is cumbersome, and sometimes impossible when you don't own the code, to implement both interfaces. Thus this PR allows adds the ability to marshal flags by those interfaces.Changes:
encoding.TextMarshalertoconvertMarshalonly AFTER checking for theflags.Marshalerinterface.encoding.TextUnmarshalertoconvertUnmarshalonly AFTER checking for theflags.Unmarshalerinterface.