Fix multiline response. Now based on EventList header.#49
Open
j0hen wants to merge 2 commits intojfernandz:developfrom
Open
Fix multiline response. Now based on EventList header.#49j0hen wants to merge 2 commits intojfernandz:developfrom
j0hen wants to merge 2 commits intojfernandz:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version of pyst2 (0.5.1) doesn't parse correctly all multiline responses. In this case for example: actions CoreShowChannels or BridgeList. There is no Events in response. Issue persists in asterisk versions 16.7.0 - 16.9.0 (tested on these versions). Small fix in this pull request might resolve this issue.
Fixes #35