Open
Conversation
Owner
|
I do not think this will work when the array contains non-POD types, e.g., an array of vectors. |
Author
|
There should be a new method for sending buffer arrays then. The methods for sending generic types are too slow. |
Owner
|
I do not think overloading something like Maybe an overload for specific array references could work, e.g., template <size_t n, size_t m>
void rpcWrite(Stream& io, uint8_t (& data)[n][m]) {
// ...
} |
|
I had the same experience. The issue would be resolved with this PR: |
bdf5cf6 to
07e9b99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Provide details about your pull request and what it adds, fixes, or changes.
Use the underlying io.write(buf, len) methods when there are multiple items to be written. This dramatically speeds up the transfer speeds.
Breaking Changes
Describe what features are broken by this pull request and why, if any.
None
Issues Fixed
Enter the issue numbers resolved by this pull request below, if any.
None
Other Relevant Information
Provide any other important details below.
Tested on my Adafruit M0 and it's about 3X the transfer speed over the USB serial console.