Support for Artifactory with auth and Host path for provider binary#68
Open
shahiinn wants to merge 1 commit into
Open
Support for Artifactory with auth and Host path for provider binary#68shahiinn wants to merge 1 commit into
shahiinn wants to merge 1 commit into
Conversation
RobinDuhan
reviewed
May 4, 2026
RobinDuhan
reviewed
May 4, 2026
Contributor
RobinDuhan
left a comment
RobinDuhan
left a comment
There was a problem hiding this comment.
Looks good, please check the comments once.
| name: {{ $authSecret }} | ||
| key: password | ||
| optional: true | ||
| - name: DOWNLOAD_ACCESS_TOKEN |
Contributor
There was a problem hiding this comment.
I am wondering if we should support private artifactories, since technically a token would exist in their K8s, and goes against our the philosophy of the provider.
shahiinn
force-pushed
the
feature/INST-21488
branch
from
ca1fdd9 to
cdab973
Compare
shahiinn
force-pushed
the
feature/INST-21488
branch
from
cdab973 to
ccb7fbd
Compare
Collaborator
|
This PR is to address #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.