feat(helm): auto-set cloud_provider env to skip cloud detection probe#82
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
m-barczyk
force-pushed
the
feat/auto-set-cloud-provider-env
branch
from
a649e35 to
894a0b9
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
The binary's getCloudProvider() function (internal/provider/provider.go#L129)
probes IMDS, Azure, and GCP metadata endpoints to detect which cloud the
node runs on:
cloudProvider := utils.GetEnvs(logs, "cloud_provider", "")
if cloudProvider == "" {
isAWS, _ := handlers.CheckIfAWS(svc, ctx)
isAzure, _ := handlers.CheckIfAzure(svc, ctx)
isGoogle, _ := handlers.CheckIfGoogle(svc, ctx)
}
However, the Helm chart never sets cloud_provider in the provider config env
array, even though the cloud is already known at template time (the user
explicitly enables aws.enabled, gcp.enabled, or azure.enabled).
cloudProvider := utils.GetEnvs(logs, "cloud_provider", "")
Never sets cloudProvider because there is not ENV for it. Auto detection
mechanism must always run.
m-barczyk
force-pushed
the
feat/auto-set-cloud-provider-env
branch
from
894a0b9 to
f84b754
Compare
RobinDuhan
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary's getCloudProvider() function probes AWS, Azure, and GCP metadata endpoints to detect which cloud the node runs on:
jfrog-credentials-provider/internal/provider/provider.go
Lines 97 to 105 in 4f055ae
However, the Helm chart never sets cloud_provider in the provider config env array, even though the cloud is already known at template time (the user explicitly enables aws.enabled, gcp.enabled, or azure.enabled).
cloudProvider := utils.GetEnvs(logs, "cloud_provider", "")Never sets cloudProvider because there is not ENV for it. Auto detection mechanism must always run.