Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed all the comments about test quality (and CI, and code testability) and will add them back in another branch, so that they dont bias the attendees, but they will be available as a sort of commentary (git diff).
I fixed ruff, the issue of showcasing a broken CI, is that the CI is broken and does not gate merges on being correct :upside_down:
I tried to make the architecture changes and the test strategy more visual, let me know what you think.
I ensured that the solution tests are working properly, and found a frequent bug : comparing tz-naive with tz-aware datetimes. I had to fix it in the non-solution code. I think it is better that way, the goal of the workshop is not to confuse the attendees about that.
I also found some regressions caused by the multiple suggestions from me you applied, nothing significant.
I advise to review (if you do it) commit-by-commit, it is much clearer that way (significant + atomic commits).