feat: add email module with API, services and UI#28
feat: add email module with API, services and UI#28Piya-Boy wants to merge 1 commit intojhd3197:mainfrom
Conversation
Made-with: Cursor
|
Hey @Piya-Boy, funny timing here. I didn't notice we were both working on the email module at the same time until your PR showed up. I already had a partial implementation going but honestly your approach was way better, splitting everything into dedicated services (Postfix, Dovecot, DKIM, SpamAssassin, Roundcube) instead of one big monolithic service was the right call. So I ended up taking your architecture as the base and merging it with what I already had, keeping your service separation, models and API structure. I also extended it with the rest of the stuff I was working on (SSO, API keys, invitations, etc) and it all landed together in #29. I updated the roadmap to mark email as completed and you're credited in the PR. I won't be merging this one directly since it's already integrated but wanted to make sure you know your work made the final result way better. Solid work, thanks for jumping in. |
|
1. Hi Juan,
Thanks so much for the feedback and the kind words! I'm glad my design
approach could contribute to making PR #29 a success.
Thanks,
ในวันที่ พุธ 4 มี.ค. 2026 เวลา 15:24 Juan Denis ***@***.***>
เขียนว่า:
… Closed #28 <#28>.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU2AKMBXJZJPBVEURJPLBX34O7R4DAVCNFSM6AAAAACWFWPH42VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRTGI2TGMJZHE2DSNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Made-with: Cursor