Added crop and delete functionality#3
Open
hamzadis wants to merge 20 commits intojhol:trigger-stufffrom
Open
Conversation
cotire has proven itself to be counter-productive. It rebuilts the pre-compiled header after any header in pulseview is modified causes a complete rebuild of all of PulseView. Also, the pre-compiled header contains a union of all the includes of all source files, which masks errors where source files are missing needed includes.
jhol
force-pushed
the
trigger-stuff
branch
2 times, most recently
from
089071a to
1fff13a
Compare
This change adds a lot of code duplication between the data::Analog and data::Logic classes. The solution could be to create a generic parent class that handles the common parts (e.g. SegmantHolder<SegmentT>), or to use a utility class.
Properly handle the case when decoders are not enabled. Use a lock when accessing data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds crop and delete functionality using the cursors as selections. As noted in the commit message, there is a lot of code duplication between the analog and logic classes. Some of the code is almost identical, except that it deals with different types. So it seems a small refactor would be in order at some point.
The erase functions handle the segments as sequential data, respecting their individual samplerate in the process. That means that this code should be mostly compatible with any future additions in that area (Sweep).