Skip to content

add "all" to "set_desktop_for_window"#40

Merged
jinliu merged 1 commit intojinliu:masterfrom
acheronfail:acheronfail/set_all_desktops_for_window
Jan 29, 2026
Merged

add "all" to "set_desktop_for_window"#40
jinliu merged 1 commit intojinliu:masterfrom
acheronfail:acheronfail/set_all_desktops_for_window

Conversation

@acheronfail
Copy link
Copy Markdown
Contributor

Fixes #39

I haven't tested KDE5 yet, unsure if the window.onAllDesktops property exists there. I'll check and report back.

@jinliu
Copy link
Copy Markdown
Owner

jinliu commented Jan 28, 2026

I think instead of another command, we can just change "set_desktop_for_window" to accept "all" as the argument. (Since it already accepts "current_desktop", it's trivial to modify the parser for "all".)

In the window menu, "All desktop" is a radio button along with other desktop radio buttons, thus it should be a special desktop number argument to align with the UI.

I'm considering dropping KDE5 support, so we can focus on KDE6 in this PR.

@acheronfail acheronfail force-pushed the acheronfail/set_all_desktops_for_window branch from fae1620 to fae1690 Compare January 28, 2026 21:30
@acheronfail
Copy link
Copy Markdown
Contributor Author

I think instead of another command, we can just change "set_desktop_for_window" to accept "all" as the argument. (Since it already accepts "current_desktop", it's trivial to modify the parser for "all".)

Makes sense - I've done that now 👍

I'm considering dropping KDE5 support, so we can focus on KDE6 in this PR.

Well that makes it easier for me! I just made it output an error if it's used in KDE5.

@acheronfail acheronfail changed the title add command "set_all_desktops_for_window" add "all" to "set_desktop_for_window" Jan 28, 2026
@jinliu jinliu merged commit b3adca7 into jinliu:master Jan 29, 2026
@acheronfail acheronfail deleted the acheronfail/set_all_desktops_for_window branch February 2, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: set_desktop_for_window to "All Desktops"

2 participants