add properties to GA4 destination#1406
Conversation
![jitsu-code-review[bot]](https://avatars.githubusercontent.com/in/3391383?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed GA4 destination changes in libs/destination-functions/src/functions/ga4-destination.ts plus the new tests.
Found one correctness concern to double-check:
ip_overrideis now forwarded fromcontext.ipwithout validation/sanitization; this can pass invalid/non-IP values through to GA4 and may degrade geolocation quality.
The rest of the context mapping additions (device/user agent/location/consent) and associated tests look good overall.
410a9e7 to
775bcdc
Compare
775bcdc to
5386713
Compare
5386713 to
58da107
Compare
There was a problem hiding this comment.
Reviewed GA4 destination changes in plus new coverage in .
I focused on correctness, security-relevant data handling, and user-visible regressions in the new request fields (device, user agent, location, consent, and IP override). I did not find additional actionable issues beyond previously resolved review threads. The added tests exercise the new mapping paths and edge-case omissions well.
There was a problem hiding this comment.
Reviewed GA4 destination changes in libs/destination-functions/src/functions/ga4-destination.ts plus new coverage in libs/destination-functions/tests/ga4-destination.test.ts.
I focused on correctness, security-relevant data handling, and user-visible regressions in the new request fields (device, user agent, location, consent, and IP override). I did not find additional actionable issues beyond previously resolved review threads. The added tests exercise the new mapping paths and edge-case omissions well.
58da107 to
e3e0982
Compare
There was a problem hiding this comment.
Reviewed the GA4 destination changes and associated tests, focusing on correctness, runtime behavior, and potential regressions in request payload construction.\n\nI found one actionable issue around handling that can send an invalid value when contains a comma-separated chain with spaces; details are in the inline comment.
There was a problem hiding this comment.
Reviewed the GA4 destination changes and associated tests, focusing on correctness, runtime behavior, and potential regressions in request payload construction.
I found one actionable issue around ip_override handling that can send an invalid value when context.ip contains a comma-separated chain with spaces; details are in the inline comment.
2 participants
No description provided.