fix build and CI/CD checks (#1)#7
Open
tfoldi wants to merge 1 commit intojizhang-cmu:foxy-humblefrom
Open
Conversation
* build: add C++17 flags * ci: initial version * ci: add deps * ci: add tf2-sensor-msgs * doc: add tf sensor msgs
|
Can confirm on a clean Ubuntu 22.04 install with ROS2 Humble that it doesn't compile without changing the CMakeLists files. I can't merge it because I'm not the author nor a contributor, but it helped me a lot, so thank you! |
|
Can also confirm that this fixed my build issues on Ubuntu 22.04 Humble which previously could not build successfully without these modifications. Thank you so much @tfoldi and @jizhang-cmu , this helped me a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6 and implements some fixes from #4