Skip to content

fix: security hardening from codebase audit (password scoping, lock file, terminal escapes)#22

Merged
jkleinne merged 5 commits into
mainfrom
fix/security-hardening
Jun 10, 2026
Merged

fix: security hardening from codebase audit (password scoping, lock file, terminal escapes)#22
jkleinne merged 5 commits into
mainfrom
fix/security-hardening

Conversation

@jkleinne

@jkleinne jkleinne commented Jun 10, 2026

Copy link
Copy Markdown
Owner

three small security hardening fixes

  • rclone password no longer goes through os.Setenv into shuttle's own env — it's injected straight into the rclone child's cmd.Env, so rsync and /proc/self/environ never see it
  • lock file moved off shared /tmp to a per-user runtime dir (XDG_RUNTIME_DIR, else a 0700 shuttle-<uid> subdir), opened O_NOFOLLOW 0600. Kills the predictable-path flock DoS and the symlink redirect on multi-user boxes
  • strip control bytes from progress text so a malicious filename can't sneak terminal escapes onto your screen

@jkleinne jkleinne merged commit 207eefb into main Jun 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant