docs: address cli-agent-skill-patterns gaps from issue #173 (pprose audit)#175
Conversation
Source-level audit (via checkout-third-party-repo) of how popular and shipped skills distribute, to ground issue #173 and keep our research current. - New research-2026-06-13-skill-distribution-landscape.md: the channel taxonomy, a distribution decision matrix, case studies across L0/L2a/L2b/L3 (taste-skill, anthropics/skills, qmd, pprose, tbd), and the skills.sh leaderboard reality (simple L0/L1 vendor knowledge skills dominate adoption). - Verified all five issue #173 gaps against pprose's install.py (dev-build pin selection, surface= drop, multi-block collapse, artifact-driven format stamps). - Current-practice corrections: Cursor now scans .agents/skills/ natively (Cursor docs); native per-agent skill dirs are proliferating. - Refreshed three stale research docs (foundational CLI-as-skill brief, standard-paths native-dirs note, meta-skill 15K->1% budget correction). - New plan-2026-06-13-cli-skill-guideline-pprose-gaps.md maps each gap to a concrete, rung-tagged guideline edit. https://claude.ai/code/session_01MvbozVS4yEWoR4pkJCMSkJ
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Secrets | Jun 13, 2026 7:43p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Coverage Report for packages/tbd
File CoverageNo changed files found. |
2c54b53 to
ade659c
Compare
Senior Engineering Review: Skill Distribution GuidanceI reviewed PR #175 ( Bottom lineI agree with the PR's main direction: the guideline should strongly recommend stopping at the lowest integration rung that works. Most tools should ship a small repo-root I would request changes before merge because a few internal contradictions still weaken the recommendation. Findings
Research corroborationThe main research claims check out.
The nuance I would add: the ecosystem is fragmenting into many native directories, but the best response is not for every CLI to write every native path itself. The durable baseline is still canonical repo-root skills plus Holistic recommendationI would make the guideline's recommendation ladder even sharper:
What tbd should do to dogfood thisI would turn the PR's recommendations into a small tbd dogfooding roadmap:
Suggested merge stanceI would not block on the tbd generator cleanup if it is tracked as a follow-up. I would block on the three documentation consistency issues above, because they are in the recommendation surface this PR is changing. |
Fold the five pprose-surfaced gaps from issue #173 into the guideline, each tagged with the ladder rung it touches so the §0 baseline stays untouched. - Name the L2b variant (§6.0, §0.3): an L2 self-installer that also writes a managed AGENTS.md block, with none of the L3 platform; pprose is the reference. Kept as a named variant within L2, not a separate renumbered rung. - Reframe format-versioning as artifact-driven, not L3-only (§6.0 closer, §6.6): any rung that writes a merged/managed artifact needs the format stamp and forward-compat guard; hooks/prime/setup/DocCache stay L3-specific. - Add the generator-side dev-build pin rule (§6.7): bake a resolvable published release, not an unpublishable dev/pre-release version. - Drop the redundant surface= tag from both marker examples (§2, §6.6); identify artifacts by location. - Add multi-block collapse to §2 (and a §6.6 pointer): collapse stale duplicate blocks to one, matching known legacy begin-prefixes. - Refresh the §6.6 native-scanning table: Cursor now scans .agents/skills/ natively; note native per-agent skill dirs are multiplying. - Update §11/§12 and References (pprose L2b variant, qmd L2, taste-skill/ anthropics L0). Sync the plan and research docs to the chosen form: record gap 1 resolved as the single named variant in the plan (Phase 1 done, Open Questions resolved), and note in the landscape research which shape was adopted vs. the rejected L2a/L2b split. https://claude.ai/code/session_01MvbozVS4yEWoR4pkJCMSkJ
ade659c to
02d4a8e
Compare
…ative, spec status) Address the three blocking findings from the senior engineering review on PR #175: - P1 (guideline §6.6): retitle "Upgrade existing installs deliberately (L3 only)" to "Upgrade managed generated artifacts deliberately" and rewrite the parenthetical around the artifact, not the rung. A plain-L2 tool (discovery-dirs only) still skips migration; the L2b variant, which merges a managed AGENTS.md block into a human-authored file, needs the format stamp and forward-compat guard even though it is not L3. Removes the contradiction with the artifact-driven rule in §6.0. - P2 (research-agent-skills-standard-paths): reconcile the Cursor claims. Cursor natively scans .agents/skills/ and .cursor/skills/ (plus the ~/ variants, recursive, with .claude/.codex compatibility loading) per the Cursor Agent Skills docs (verified 2026-06-13). Move Cursor from the installer-reach bucket to verified-native in both the table and the precision note, and make the verified-native vs. Vercel-installer- reach distinction explicit. - P3 (plan spec): flip Status from "Draft (not yet applied)" to "Implemented"; the Open Questions and Phase 1 were already marked resolved in the prior commit. Record the review's dogfooding roadmap as tracked Phase 2 follow-ons. https://claude.ai/code/session_01MvbozVS4yEWoR4pkJCMSkJ
|
Thanks for the detailed review. Addressed the three blocking findings in P1 — §6.6 "L3 only" upgrade scope. Retitled "Upgrade existing installs deliberately (L3 only)" → "Upgrade managed generated artifacts deliberately", and rewrote the parenthetical around the artifact, not the rung: a plain-L2 tool (discovery-dirs only, full overwrite) still skips migration, but the L2b variant — which merges a managed P2 — Cursor native-scan contradiction. Verified against the current Cursor Agent Skills docs: native recursive scan of P3 — spec reads pre-implementation. Flipped Status from "Draft (not yet applied)" → "Implemented … this spec is a record, not an open proposal." (The Open Questions and Phase 1 checklist were already marked resolved in Non-blocking items, considered:
One heads-up: since your review (made at Generated by Claude Code |
Closes #173.
Folds the five pprose-surfaced gaps from #173 into the
cli-agent-skill-patternsguideline, plus a wider distribution audit that keeps our research current. Each guideline edit is tagged with the ladder rung it touches, so the §0 simple baseline stays untouched. All five gaps were verified against pprose's workinginstall.py(not just the issue prose) before editing.Guideline edits (the five gaps)
AGENTS.mdblock but takes on none of the L3 platform (no hooks/prime/setup/DocCache). Named as a variant within L2 (reference:pprose); the four-rung ladder L0–L3 is unchanged, with no L2a/L2b renumber — the owner chose the lighter single-named-sentence form over a full ladder split.qmdstays the plain-L2 reference.AGENTS.mdblock, or a committed generated skill shared across versions) needs the format stamp and forward-compat guard. Hooks/prime/setup/DocCache stay L3-specific.DISCOVERY_VERSION+is_pypi_release). A dev/editable checkout's version (0.1.1.dev49+abc1234) never resolves viauvx/npx.surface=tag (§2, §6.6) — both marker examples now carry onlyformat=fNN; artifacts are identified by location. (pprose already dropped it;tbd/flowmarkstill emit it — see follow-on below.)Current-practice corrections (§6.6 native-scanning table): Cursor now scans
.agents/skills/natively (verified against Cursor docs); native per-agent skill dirs (.cursor/skills/,.github/skills/,.gemini/skills/, Google Antigravity.agent/skills/, …) are proliferating. §11/§12 and References updated (pprose L2b variant, qmd L2, taste-skill/anthropics L0).Research (the broader audit)
research-2026-06-13-skill-distribution-landscape.md— channel taxonomy, a distribution decision matrix (when each rung/channel is right), case studies across L0/L2/L2b/L3 (taste-skill, anthropics/skills, qmd, pprose, tbd), and the skills.sh leaderboard reality: the most-installed skills are simple L0/L1 vendor knowledge skills (Vercelfind-skills~2.0M, Anthropicfrontend-design~540K, Microsoft Azure ~5.8M), not self-installing platforms. Distribution complexity does not track adoption. The doc records both shapes considered for gap 1 (the L2a/L2b split vs. a single named sentence) and which was adopted.plan-2026-06-13-cli-skill-guideline-pprose-gaps.md— maps each gap to its edit; Phase 1 marked done and the gap-1 Open Question resolved to the single named variant.Scope notes
format:md); new content strictly follows the common-doc guidelines (no spaced em dashes; "and" not+/&in new prose; Title Case headings). Pre-existing+in untouched sections of the guideline was left alone to keep this diff substantive rather than a repo-wide style sweep.tbdgenerator change —setup.tsemitssurface=agents-mdon theAGENTS.mdbegin line, which the guideline now calls unnecessary. Dropping it is safe (block is rewritten whole; detection is prefix-anchored) but is a code change with golden/drift-test updates, best tracked separately.https://claude.ai/code/session_01MvbozVS4yEWoR4pkJCMSkJ
Generated by Claude Code