break cycles, add flag for detecting cycles#7
Merged
Merged
Conversation
skudasov
force-pushed
the
break-on-cycle
branch
9 times, most recently
from
b4ae21c to
11fbd2e
Compare
jmank88
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a back-edge DFS algorithm for cycle detection and skips cycles, preventing the tool from hanging in such cases.
I've chosen DFS because of readability and simplicity. This algorithm can miss some cycles due to the traversal order, but eventually it will discover all module cycles if we start fixing them.
Tested on this PR, the tool no longer hangs, on "main" it produces the same
go.md