Skip to content

Fix detached nodes #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmank88 merged 1 commit into from
May 14, 2026
Merged

Fix detached nodes #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ func (s *state) transitiveReduction() {
s.deps[m] = slices.DeleteFunc(deps, func(d string) bool {
// BFS for indirect paths to d, tracking nodes we touch along the way
var touched []string
// visited guards against cycles in the graph
visited := make(map[string]struct{})
// visited prevents BFS from looping on cycles; pre-marking m blocks paths like m→…→m→d from counting as indirect
visited := map[string]struct{}{m: {}}
children := slices.DeleteFunc(slices.Clone(deps), func(s string) bool { return s == d }) // exclude direct
for len(children) > 0 {
var next []string
Expand Down
Loading