Implement JEP-18 let expression with lexical scoping#63
Open
joshrotenberg wants to merge 2 commits intojmespath:masterfrom
Open
Implement JEP-18 let expression with lexical scoping#63joshrotenberg wants to merge 2 commits intojmespath:masterfrom
joshrotenberg wants to merge 2 commits intojmespath:masterfrom
Conversation
Implements official JEP-18 let expressions as an optional feature flag. The let expression introduces lexical scoping with the syntax: let $var = expr, $var2 = expr2 in body Features per JEP-18 specification: - Contextual keywords: 'let' and 'in' are not reserved - Variable references use $ prefix syntax - Multiple comma-separated bindings supported - Lexical scoping with inner scope shadowing - Undefined variable triggers runtime error - Projection stopping behavior preserved - Add let-expr feature flag to Cargo.toml - Add Variable and Assign tokens to lexer (feature-gated) - Add VariableRef and Let AST nodes - Implement let expression parsing in parser - Add scope stack to Context for variable lookup - Implement Let and VariableRef evaluation in interpreter - Add comprehensive tests for scoping behavior - All 861 compliance tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements JEP-18 (Lexical Scoping) as an optional feature. Let expressions allow binding values to variables for use within an expression, enabling queries that reference elements from outer scopes.
Syntax
Example
Features
Per JEP-18 specification:
letandinare contextual keywords (not reserved)$namesyntaxFeature-gated behind
let-exprto maintain backward compatibility:Changes
let-exprfeature flag to Cargo.tomlVariableandAssigntokens to lexer (feature-gated)VariableRefandLetAST nodesContextfor variable lookupLetandVariableRefevaluation in interpreterTesting
Known Limitations
Using
letorinas field names immediately before theinkeyword (e.g.,let $x = foo.let in ...) requires more complex parser lookahead. Workaround: use quoted identifiers (let $x = foo."let" in ...).