Support react-router-relay via applyRouterMiddleware.

[joonhocho]

@jmurzy,
I finally got it working with react-router-relay.
Please take a look and let me know what you think.

[joonhocho]

Related #21.

[jmurzy]

Thanks. At first sight it looks good. Do you have an example repo with react-router-relay I can use to run a few tests?

I'm currently working on #17 which will require refactoring a few things internally. Once I land a fix for that, this will be much easier to merge. Please bare with me as I catch up on my backlog.

🍺

[joonhocho]

I will definitely add examples tomorrow.

[joonhocho]

@jmurzy, Just created todo example with relay:
https://github.com/joonhocho/react-native-router-relay-todo

[jmurzy]

Awesome! Thanks.

🍺

[joonhocho]

@jmurzy,
There are currently few bugs I can spot with the todo app.
First, relay initially fetches data for /complete and /any. Not sure, why it fetches /complete.
Second, when you navigate to either complete tab, you will see two list all and complete on the screen. The same also happens for active tab.

[joonhocho]

I've been looking into why it was rendering two lists after switching tabs, and I've found that it's because I am using Route as a parent route instead of StackRoute or TabsRoute.

RouteView does not supply configureTransition and applyAnimation to NavigationAnimatedView unlike StackRouteView or TabsRouteView.

As result, NavigationAnimatedView._onProgressChange does not get called which is responsible for removing stale scenes.

Also, Relay initially fetching /complete and /any turned out to be not a bug. /complete is loaded by TodoListFooter.

I've noticed that NavigationAnimatedView is being killed. Will it fix the above RouteView issue of not having any transition animation?

[joonhocho]

More investigation on the bug.
Not having the applyAnimation on RouteView was not the cause of the issue.
The bug was caused by NavigationAnimatedView.componentDidUpdate.
Removing the if statement fixed it.

[joonhocho]

facebook/react-native#7422 may be related.

[joonhocho]

Hopefully new NavigationTransitioner fixes the issue.

[jmurzy]

Yeah. Unfortunately though, patches that address that specific issue, facebook/react-native@c57bac4 and facebook/react-native@b4d15d3, did not make it into 0.29-rc. I'm trying to get those cherry picked into 0.29, facebook/react-native#8333.

#17 and #3 are also related.