Upgrade pdfcpu dependency to 0.11.0#1
Merged
Conversation
Required to support some PDF files.
jo3-l
approved these changes
Sep 18, 2025
Owner
jo3-l
left a comment
jo3-l
left a comment
There was a problem hiding this comment.
Thanks, glad to hear the tool was of use to you!
Owner
|
Hm, CI looks like it's failing on the |
Contributor
Author
|
Seems one of the module updates required go 1.23 - upgrading the version used in the CI test looks like it resolves the problem. (I'm not a go programmer though so beware! :) ) |
Owner
|
Looks good. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jo3-l, thanks for the useful tool! I know that much of the functionality has been subsumed into pdfcpu itself these days, but I still very much prefer using your bookmark format to JSON.
This pull request simply upgrades the version of the pdfcpu dependency to 0.11.0, requiring a 1-line change to accommodate a change in the pdfcpu bookmarks API. Without this upgrade, markpdf produces the following error when applied to some PDF files:
With the upgrade in place, markpdf again works.