feat: add upMetricName params to allow for up metric name customization#140
Open
BreizhHardware wants to merge 2 commits into
Open
feat: add upMetricName params to allow for up metric name customization#140BreizhHardware wants to merge 2 commits into
BreizhHardware wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration option to customize the name of the "up" metric in the HTTP metrics library, enhancing flexibility for users. The most important changes include updates to the documentation, the addition of the new option in the code, and its integration into the metric creation logic.
Documentation Updates:
upMetricNameoption in theREADME.md, which allows users to customize the name of the "up" metric. The default remains asup.Code Enhancements:
upMetricNameconfiguration option in themainfunction ofsrc/index.js, defaulting toupif not provided.upMetricNameinstead of the hardcodedup, ensuring the new option is applied when creating the "up" metric.Fix the issue #122