Skip to content

fix: use shared IB status for sidebar state#2

Open
damian123 wants to merge 2 commits intojoemccann:mainfrom
damian123:fix/sidebar-status-shared-ib-health
Open

fix: use shared IB status for sidebar state#2
damian123 wants to merge 2 commits intojoemccann:mainfrom
damian123:fix/sidebar-status-shared-ib-health

Conversation

@damian123
Copy link
Copy Markdown

Summary

  • use the shared IB status socket for the sidebar footer badge instead of the price-subscription socket
  • keep the Orders footer connected even when the page has no quote subscriptions
  • add unit and Playwright regression coverage for the empty Orders-page case

Validation

  • npx vitest run --config ../vitest.config.ts web/tests/workspace-shell-sidebar-status.test.tsx
  • npx playwright test --config playwright.no-server.config.ts e2e/ws-connection-stability.spec.ts --grep "empty orders page still shows CONNECTED"

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 5, 2026

@damian123 is attempting to deploy a commit to the Joe McCann's projects Team on Vercel.

A member of the Team first needs to authorize it.

@damian123
Copy link
Copy Markdown
Author

Local validation on head f1c54cb:

  • npm run build passed
  • npx vitest run --config ../vitest.config.ts web/tests/workspace-shell-sidebar-status.test.tsx passed
  • targeted browser regression passed: npx playwright test --config playwright.config.ts e2e/ws-connection-stability.spec.ts --grep "empty orders page still shows CONNECTED"
  • touched-surface typecheck grep is clean: npm run typecheck | rg "WorkspaceShell|workspace-shell-sidebar-status|ws-connection-stability" returned no matches

Notes:

  • The remaining Vercel failure is the same upstream authorization issue seen on the other PRs, not a branch build failure.
  • Ad hoc runs of the full ws-connection-stability.spec.ts file and some standalone status-context tests still hit existing local auth/baseURL and Clerk test-harness issues outside this fix scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant