Add .env file support#167
Open
sudoish wants to merge 13 commits into
Open
Conversation
|
I realised this would probably supersede #171 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.envfile support to xc, resolving #162.Changes
.envand.env.localfiles at startup (before task parsing)--env-file <path>to load a custom env file--no-envto skip loading .env filesImplementation Details
Load Order
Environment variables are loaded in this order (later overrides earlier):
.envfile.env.localfileEnv:statementsexportstatementsFiles Added
internal/dotenv/- New package for .env loadingloader.go- Core implementation with security checksloader_test.go- Full test coverage.env.example- Template file for usersFiles Modified
cmd/xc/main.go- Integration and CLI flagsREADME.md- Complete documentation section.gitignore- Added .env patternsDesign Decisions
.env.localoverride: Standard pattern for local secrets (git-ignored)Env:statements still workTesting
All tests passing:
$ go test ./... ok github.com/joerdav/xc/cmd/xc ok github.com/joerdav/xc/internal/dotenv ok github.com/joerdav/xc/parser/parsemd ok github.com/joerdav/xc/parser/parseorg ok github.com/joerdav/xc/runManual testing completed:
Example Usage
Before (cluttered task definition):
After (with .env):
With
.env:And
.env.localfor local overrides:Breaking Changes
None. This is fully backward compatible.
Checklist
Closes #162