[bazel] Separate test helper code from actual tests.#6053
Merged
Conversation
…ing. We needed to depend on `scala_test` target and thus bring in tons of individual test code to get a minor amount of helper code for tests. Rearranged code so that we can define separate package for the helper code and only use that as dependencies. Also made all `scala_test` targets only package visible to reduce likelihood of people importing them.
maltek
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed to depend on
scala_testtargets and thus bring in tons ofindividual test code to get a minor amount of helper code for tests.
Rearranged code so that we can define separate packages for the helper
code and only use that as dependencies.
Also made all
scala_testtargets only package visible to reducelikelihood of people importing them. Add build fail on visibility
been set for scala_test targets for enforcement of this.