Added proxy support#9
Open
PlasmaPower wants to merge 8 commits into
Open
Conversation
PlasmaPower
force-pushed
the
master
branch
2 times, most recently
from
January 10, 2016 02:49
183f852 to
879309e
Compare
Contributor
Author
|
TODO: Add a better way to input a proxy password, as passing it though an argument means any user can read it with |
PlasmaPower
force-pushed
the
master
branch
4 times, most recently
from
January 21, 2016 14:17
537c3c3 to
b058e85
Compare
Owner
There was a problem hiding this comment.
Not sure about the c++11 thing. Might break support for older distros.
Contributor
Author
There was a problem hiding this comment.
I'm using it for static map initialization. If the older distros are important, I'm pretty sure I can do that differently.
Also enabled C++11 for static map initialization
|
Why not get it from environment variables HTTP_PROXY and HTTPS_PROXY ? |
Contributor
Author
|
@hazcod not a bad idea, but it would require parsing them for libtorrent. |
|
RIP? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I have been able to determine that traffic is going over the proxy, I haven't been able to test if any packets are leaking. If someone could figure out how to test for that it would be great.