fix(terminal): open .md file links in built-in viewer#48
Merged
johannesjo merged 1 commit intojohannesjo:mainfrom Mar 29, 2026
Merged
fix(terminal): open .md file links in built-in viewer#48johannesjo merged 1 commit intojohannesjo:mainfrom
johannesjo merged 1 commit intojohannesjo:mainfrom
Conversation
The Ctrl/Cmd+click modifier requirement meant .md files always took the external path since metaKey was always true. Use Shift as the modifier to force external open instead. - Cmd/Ctrl+click on .md → opens in built-in viewer - Cmd/Ctrl+Shift+click on .md → opens externally - Cmd/Ctrl+click on other files → opens externally (unchanged)
Owner
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes .md file links always opening externally instead of in the built-in markdown viewer.
Problem
After #45 was merged and Ctrl+click was added as a requirement in
933931a, the.mdviewer check (!event.metaKey) was always false on Mac since Cmd is required to activate the link. All.mdfiles fell through to the external open path.Fix
Use
event.shiftKeyas the "open externally" modifier instead:.md→ opens in built-in viewer.md→ opens externallyTest plan
.mdfile path in terminal — opens in viewer dialog.mdfile path — opens externally.tsfile — opens externally