Skip to content

feat: support dat files with more than one rom per entry.#1

Open
haxorjim wants to merge 1 commit intojohn32b:masterfrom
haxorjim:master
Open

feat: support dat files with more than one rom per entry.#1
haxorjim wants to merge 1 commit intojohn32b:masterfrom
haxorjim:master

Conversation

@haxorjim
Copy link
Copy Markdown

@haxorjim haxorjim commented Dec 16, 2019

This solution adds all roms to the list. It's not ideal if all someone is after is a distinct complete collection, but better than not being able to process certain data files.

@john32b
Copy link
Copy Markdown
Owner

john32b commented Dec 16, 2019

Hi, it's been a while since I worked on this project.
Yes, the current situation with multiple roms is junky. I remember I did it to exit error to be on the safe side and not let any false positives, etc. 😅

I wish I had written some unit tests. Your code looks fine. Thanks for the contrib.
So in the case a user does BUILD , engine encounters multiple roms, then for each file in the entry it would try to create the same filename e.g. game.zip but it checks that file exists and would skip or overwrite depending on flag.

This is ok,, but I think that the user should be notified that such thing occurred, else they are going to think that their newly built romset is fine (but some files are missing!)
Perhaps a warning message and skip building the multiple roms entries would be safer.

Also, are there many no-intro romsets with multiple roms out there? I am only aware of the PSP/PSN where just some entries just have lots of files.

@haxorjim
Copy link
Copy Markdown
Author

I haven't had time to look into your questions about the romsets yet. I'll circle back to this at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants