Skip to content

sanitize message at the repository level #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
sirilyan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

sanitize message at the repository level #71

sirilyan wants to merge 1 commit into from

Conversation

@sirilyan
Copy link
Collaborator

@sirilyan sirilyan commented Apr 13, 2024

  1. Make message display (chats list and chat history) render HTML.
  2. The message repository must defang any HTML that comes in, so use sanitize-html on it.
  3. When the user posts to the messaging/create endpoint, defang whatever HTML they may try to submit.

@sirilyan sirilyan requested a review from johnHackworth April 13, 2024 07:29
@sirilyan sirilyan linked an issue Apr 13, 2024 that may be closed by this pull request
Received chat messages that contain HTML render raw <tags> #64
Open
@sirilyan
Copy link
Collaborator Author

sirilyan commented Apr 13, 2024

I'm pretty sure messages only show up in the chat panes, but we should double-check that before merging

@sirilyan sirilyan marked this pull request as draft April 14, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnHackworth johnHackworth Awaiting requested review from johnHackworth

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Received chat messages that contain HTML render raw <tags>

1 participant

@sirilyan