Make use of Pcov within Docker containers#9
Closed
desrosj wants to merge 7 commits into
Closed
Conversation
…Abilities API tests. These are redundant: `WP_UnitTestCase_Base::tear_down()` runs `::_restore_hooks()`, which restores `$wp_filter`/`$wp_actions` to a pre-test baseline, so hooks added during a test are removed automatically. Follow-up to [61032]. Props mohamedahamed, gziolo, westonruter, SergeyBiryukov. Fixes #65301. git-svn-id: https://develop.svn.wordpress.org/trunk@62405 602fd350-edb4-49c9-b593-d223f7449a82
Recent attempts to change the `BASE_TAG` version in the Performance Testing workflows in [60324] and [62402] have failed due to memory exhaustion errors when trying to download the version using WP-CLI in the local Docker environment. While the. performance tests are run within the Docker environment, there’s no hard requirement for the `wp core download` command to happen through the `wordpressdevelop/cli` conatiner. This adjusts the workflow to perform the failing WP-CLI call within the GitHub Action runner and outside of Docker to avoid the memory exhaustion issue. Props westonruter, swissspidy. Fixes #65289. git-svn-id: https://develop.svn.wordpress.org/trunk@62406 602fd350-edb4-49c9-b593-d223f7449a82
This adds `9.7` (released on April 21, 2026) to the relevant testing strategies and makes it the default version in the local Docker environment. MySQL 9.7 is also an LTS release. Props chrisdavidmiles. See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@62407 602fd350-edb4-49c9-b593-d223f7449a82
…of `spl_object_hash()` to construct unique IDs. * Also use `spl_object_id()` similarly when registering and unregistering classic widgets. * Improve typing and phpdoc in `_wp_filter_build_unique_id()`. Return `null` for malformed callbacks. * Add tests for `_wp_filter_build_unique_id()`. * Improve type safety of `WP_Hook::add_filter()` in case an invalid callback is provided for parity with `::has_filter()` and `::remove_filter()`. Developed in WordPress#11865 Follow-up to r46220, r46801, r60179. Props bor0, westonruter, SergeyBiryukov, schlessera, arshidkv12, knutsp, spacedmonkey, swissspidy. See #64898. Fixes #58291. git-svn-id: https://develop.svn.wordpress.org/trunk@62408 602fd350-edb4-49c9-b593-d223f7449a82
PCOV is a dedicated coverage reporting tool that performs significantly faster than Xdebug in coverage mode. This reduces the time that tests with coverage enabled take to run by around 50%. This also removes the HTML report generation which was producing unusable artifacts in excess of 7 GB in size. Props johnbillion, desrosj, swissspidy See #64893 git-svn-id: https://develop.svn.wordpress.org/trunk@62409 602fd350-edb4-49c9-b593-d223f7449a82
desrosj
force-pushed
the
use-pcov-within-docker-container
branch
from
23cc3ba to
454ef97
Compare
Author
|
Closing in favor of WordPress#11949. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes WordPress#11618 to make use of the changes in WordPress/wpdev-docker-images#210.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.