fix(landing): ship favicon + icons to prod, fix X share preview#51
Merged
johnnichev merged 1 commit intomainfrom Apr 8, 2026
Merged
fix(landing): ship favicon + icons to prod, fix X share preview#51johnnichev merged 1 commit intomainfrom
johnnichev merged 1 commit intomainfrom
Conversation
Deploy workflow now copies landing/favicon.svg, favicon.ico, apple-touch-icon.png, and landing/assets/* into the built site, resolving 404s on production GitHub Pages that were breaking the browser tab favicon and the X/Twitter share card. - Add apple-touch-icon.png (180x180) and favicon.ico (16/32/48) generated by a new scripts/build_favicons.py that redraws the [ • ] mark from primitives (no font or SVG-renderer dependency). - Add og:image:secure_url meta tag for older Slack/LinkedIn unfurlers. - Collapse 3 wordmark variants to just variant 3 (terminal banner art), removing the ?logo= URL param, localStorage state, and ~85 lines of variant-switching CSS + markup. - Add .playwright-mcp/ to .gitignore (tool artifact).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
landing/favicon.svg,favicon.ico,apple-touch-icon.png, andlanding/assets/*into the built MkDocs site. This was the root cause of the missing X/Twitter share card and the missing browser-tab favicon.apple-touch-icon.png(180×180) so iOS Home Screen / Safari pinned tab show the[ • ]brand mark instead of a screenshot.favicon.ico(16/32/48 multi-size) as a legacy fallback for older browsers and Windows tile cache.og:image:secure_urlmeta tag — cheap insurance for older Slack/LinkedIn unfurlers that sometimes need it even whenog:imageis already HTTPS.?logo=URL param, localStorage persistence,data-logoattribute machinery, and ~85 lines of variant-switching CSS + markup.scripts/build_favicons.pyredraws the mark from primitives (rectangles + ellipse) rather than rendering the SVG, so CI doesn't needlibrsvg,cairosvg, orJetBrains Monoinstalled..playwright-mcp/to.gitignore(tool artifact directory).Test plan
Deploy Documentationworkflow runs green on mergecurl -I https://selectools.dev/favicon.svg→HTTP 200(currently 404)curl -I https://selectools.dev/favicon.ico→HTTP 200curl -I https://selectools.dev/apple-touch-icon.png→HTTP 200curl -I https://selectools.dev/assets/og-image.png→HTTP 200(currently 404)https://selectools.dev/?v=3on X — confirm share card renders with the 1200×630 og-image + tagline (note: the?v=3cache-bust forces X to re-crawl past its stale cache)https://selectools.dev/in iOS Safari → Share → Add to Home Screen → confirm the[ • ]icon appears (not a screenshot)python3 scripts/build_favicons.pyruns clean from a fresh clone (reproducibility check)Notes
(#NN)house convention onmain.selectools.devURL may still pull the old (empty) card. Append?v=3(or any query string) to force a fresh twitterbot fetch.