Skip to content

Ctx vs ctx #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chmill-zz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ctx vs ctx #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ababbad
Initial plan
Copilot Jul 2, 2025
206db35
Export StateObject.ctx field as Ctx and update all references
Copilot Jul 2, 2025
799f962
Merge pull request #1 from chmill-zz/copilot/fix-3c5b8f26-69b4-45db-8…
chmill-zz Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions fsets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ type StateObject[T any] struct {
// Data is any data related to this call.
Data T

// ctx is the context for this call. If a context is not provided, it will default to context.Background().
ctx context.Context
// Ctx is the context for this call. If a context is not provided, it will default to context.Background().
Ctx context.Context

// err is an error that can be set by any function in the call chain. If this is set, the call chain will stop.
err error
Expand All @@ -228,7 +228,7 @@ func (s *StateObject[T]) GetStop() bool {
// SetCtx sets the context for the StateObject. This is not used by users but is provided for
// the fsets compiler.
func (s *StateObject[T]) SetCtx(ctx context.Context) {
s.ctx = ctx
s.Ctx = ctx
}

// SetErr sets an error on the StateObject. This will stop the call chain and return the error in Err().
Expand Down Expand Up @@ -256,7 +256,7 @@ func (c C[T]) exec(so StateObject[T]) (StateObject[T], error) {
return c.F(so)
}
err := c.B.Retry(
so.ctx,
so.Ctx,
func(context.Context, exponential.Record) error {
var err error
so, err = c.F(so)
Expand Down Expand Up @@ -308,7 +308,7 @@ func (f *Fset[T]) Run(ctx context.Context, so StateObject[T]) StateObject[T] {
if ctx == nil {
ctx = context.Background()
}
so.ctx = ctx
so.Ctx = ctx

if f.compiled != nil {
// If we have a compiled version, use that.
Expand Down Expand Up @@ -349,7 +349,7 @@ type PromiseQueue[T any] chan<- promises.Promise[StateObject[T], StateObject[T]]
// Send sends a promise to the PromiseQueue. This is a blocking call until the promise is sent or the context is done.
// The context is attached to the StateObject in the promise, so it can be used for cancelation.
func (pq PromiseQueue[T]) Send(ctx context.Context, p promises.Promise[StateObject[T], StateObject[T]]) error {
p.In.ctx = ctx // Ensure the context is set on the StateObject.
p.In.Ctx = ctx // Ensure the context is set on the StateObject.
select {
case <-ctx.Done():
return context.Cause(ctx)
Expand Down Expand Up @@ -422,7 +422,7 @@ func (f *Fset[T]) parallel(ctx context.Context, n int, options ...ParallelOption
ctxNoCancel,
func(ctx context.Context) error {
// Run the Fset with the provided StateObject.
result := f.Run(so.ctx, so)
result := f.Run(so.Ctx, so)
promise.Set(ctxNoCancel, result, result.Err())
if po.out != nil {
po.out <- promise
Expand Down
2 changes: 1 addition & 1 deletion fsets_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func TestExec(t *testing.T) {

for _, test := range tests {
so := StateObject[Data]{}
so.ctx = t.Context()
so.Ctx = t.Context()
so, err := test.c.exec(so)
switch {
case test.wantErr && err == nil:
Expand Down