Conversation
munoztd0
changed the title
munoztd0
force-pushed
the
multicomp_lyt_fun
branch
from
e6723cd to
3c2e245
Compare
| } | ||
|
|
||
| lvls_to_keep <- levels_from_comp_map(comp_map, fulldf, ref_lvls, comp_vars, combo_map) | ||
| restrict_facets(lvls_to_keep, op = "keep")(ret, spl, fulldf) |
There was a problem hiding this comment.
@gmbecker where is this function defined? I get
Error applying custom split function: could not find function "restrict_facets"
when running tests
There was a problem hiding this comment.
Ah, sorry, I forgot to update the description file. Its in rtables in aPR that I had thought was merged in but it wasn't. should be soon: insightsengineering/rtables#1081
| } | ||
|
|
||
| ctrl_span <- unique(colspan_trt_map[[spanvar]])[2] ## assume second is non-active | ||
| ctrl_vals <- colspan_trt_map[colspan_trt_map[[spanvar]] == ctrl_span, trtvar] |
There was a problem hiding this comment.
shouldn't it take into account that less control groups can be requested via comp_map? Eg only against Pbo?
There was a problem hiding this comment.
Technically, I think this is better interpreted as "possible control groups", if a comp_map is specified, that will be used when constructing the actual risk difference columns.
I agree we need a test to confirm this though, and if it is causing levels to show up where they shouldn't we'll need to fix it.
3 participants
Not intended for immediate merge, but for team to look through and review approach, with merge after discussions.
Checks