Conversation
…ol 1, instead of whitespaces
|
made a rhub check -> https://github.com/johnsonandjohnson/junco/actions/runs/24786611898 |
There was a problem hiding this comment.
why did the docx snapshots change? This should be only changes. related to the tidytlg update, which we don't use for docx export, right?
There was a problem hiding this comment.
a new version of flextable was released to CRAN (v0.9.11) since we published junco v0.1.13. Flextable v0.9.11 is the version that is being installed and used by the CI pipeline, and this new version makes the snapshots change. This is why I changed the snapshot tests from junco v0.1.6 (the next release) to use officer::docx_summary(), to be more robust and less sensitive to changes.
In any case I visually inspected the docx files generated by the unit tests and they look ok.
Pull Request
Due to tidytlg recent CRAN release v0.12.0, tt_to_tlgrtf() and internally gentlg_single() now replace whitespaces in the header col 1 with left-indentation RTF markup. This makes our snapshot testing fail. This PR contains updated snapshots for the RTFs.
Checks