Skip to content

patch release with updated RTF snapshots#279

Open
eanokian wants to merge 4 commits intomainfrom
patch-release-updated-rtf-snapshots
Open

patch release with updated RTF snapshots#279
eanokian wants to merge 4 commits intomainfrom
patch-release-updated-rtf-snapshots

Conversation

@eanokian
Copy link
Copy Markdown
Collaborator

@eanokian eanokian commented Apr 22, 2026

Pull Request

Due to tidytlg recent CRAN release v0.12.0, tt_to_tlgrtf() and internally gentlg_single() now replace whitespaces in the header col 1 with left-indentation RTF markup. This makes our snapshot testing fail. This PR contains updated snapshots for the RTFs.

Checks

  • (Have you updated the changelog.md ?)

@eanokian eanokian requested review from gmbecker and munoztd0 April 22, 2026 08:23
@eanokian eanokian changed the title updated RTF snapshots, which now contain left-indents in the header c… patch release with updated RTF snapshots Apr 22, 2026
@eanokian eanokian marked this pull request as ready for review April 22, 2026 09:12
@eanokian eanokian self-assigned this Apr 22, 2026
Copy link
Copy Markdown
Collaborator

@munoztd0 munoztd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, !

@munoztd0
Copy link
Copy Markdown
Collaborator

made a rhub check -> https://github.com/johnsonandjohnson/junco/actions/runs/24786611898
and @gmbecker I just run the build() and send it through to winbuilder

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did the docx snapshots change? This should be only changes. related to the tidytlg update, which we don't use for docx export, right?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new version of flextable was released to CRAN (v0.9.11) since we published junco v0.1.13. Flextable v0.9.11 is the version that is being installed and used by the CI pipeline, and this new version makes the snapshots change. This is why I changed the snapshot tests from junco v0.1.6 (the next release) to use officer::docx_summary(), to be more robust and less sensitive to changes.
In any case I visually inspected the docx files generated by the unit tests and they look ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants