Fix anno_barplot number placement with explicit ylim and reverse axes#1261
Open
foertsch wants to merge 2 commits into
Open
Fix anno_barplot number placement with explicit ylim and reverse axes#1261foertsch wants to merge 2 commits into
foertsch wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer note: I kept this as two separate commits on purpose so each fix can be reviewed or cherry-picked independently.
2bc989eis the narrower#1248fix for explicitylimf74fddais the reverse-axis follow-up for#1247If you'd prefer, I can also split these into two separate PRs, but I kept them together since they touch the same
anno_barplot()code path and share related regression coverage.Summary
ylimwhenadd_numbers = TRUECommit breakdown
2bc989eRespect explicit ylim in anno_barplot with add_numbersdata_scaleunchanged whenylimis explicitly suppliedf74fddaFix reverse anno_barplot number spacing and labelsdata_scalejust to fit labelsTests
Added:
tests/testthat/testthat-AnnotationFunction-barplot-explicit-ylim.Rtests/testthat/testthat-AnnotationFunction-barplot-reverse.RVerified locally with: