Skip to content

Allow support for any videoOrientation #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Idomo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow support for any videoOrientation #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ece8772
Allow support for any videoOrientation
Idomo Nov 21, 2018
dfc58b1
Update CameraViewController.swift
Idomo Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SwiftDocumentScanner/Classes/Controllers/CameraViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ open class CameraViewController: UIViewController, AVCaptureVideoDataOutputSampl
public var preset: AVCaptureSession.Preset = .high
public var videoGravity: AVLayerVideoGravity = .resizeAspectFill
public var lowLightBoost: Bool = false

public var videoOrientation: AVCaptureVideoOrientation = .portrait
public var tapToFocus: Bool = false
public var flashMode: AVCaptureDevice.FlashMode = .off

Expand All @@ -49,7 +49,7 @@ open class CameraViewController: UIViewController, AVCaptureVideoDataOutputSampl

let previewLayer = AVCaptureVideoPreviewLayer(session: session)
previewLayer.videoGravity = videoGravity
previewLayer.connection?.videoOrientation = .portrait
previewLayer.connection?.videoOrientation = videoOrientation
view.layer.insertSublayer(previewLayer, at: 0)
self.previewLayer = previewLayer

Expand Down Expand Up @@ -94,7 +94,7 @@ open class CameraViewController: UIViewController, AVCaptureVideoDataOutputSampl

previewLayer?.frame = view.bounds
previewLayer?.videoGravity = videoGravity
previewLayer?.connection?.videoOrientation = .portrait
previewLayer?.connection?.videoOrientation = videoOrientation
}

public func takePhoto() {
Expand Down