Add custom scorecards generator - #122
Merged
Merged
Conversation
jonatanklosko
left a comment
Owner
There was a problem hiding this comment.
Looks great!
I didn't look at the UI code too closely, but as long as it gets the job done, it's all good :p
One UI nit: currently there is a lot of nested borders/boxes:
We should kill at least one level of nesting. I think what we can do is to have each section as its own card (rather than all sections wrapped in a single card). The "Add event" button can be below all cards.
Owner
|
(Also, I just pushed a fix, so there is a conflict in the scorecards code that needs to be resolved) |
Contributor
Author
|
Owner
|
Glorious :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds a new tab to the "printing" section that allows users to print fully customizable scorecards. It will be very useful for unofficial events, as well as in various situations when it's necessary to print only one scorecard for a particular competitor
Screenshots:

